From bcf042fc8d3f94e8d41be3e06bc8a2ee1858fc58 Mon Sep 17 00:00:00 2001 From: Sadek Baroudi Date: Mon, 31 Oct 2022 13:21:22 -0700 Subject: [PATCH] fixed github workflow build such that firmware is too large doesn't generate an error, but everything else does --- bin/fp_build.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bin/fp_build.sh b/bin/fp_build.sh index 892fa583d3..a412429003 100755 --- a/bin/fp_build.sh +++ b/bin/fp_build.sh @@ -238,9 +238,11 @@ process_build_string() { if [[ "${run_build}" == "yes" ]]; then echo "fp_build.sh: Running QMK Build...." echo "" - eval "${build_string}" + build_run_output=`${build_string}` build_run_status=$? - if [[ $build_run_status -ne 0 ]]; then + echo "output: ${build_run_output}" + echo "exit status: ${build_run_status}" + if [[ $build_run_status -ne 0 && "${build_run_output}" != *"The firmware is too large"* ]]; then echo "${0} build run failed with status ${build_run_status}" exit $build_run_status fi